Update diagnostics page re: telemetry info#19620
Merged
rmloveland merged 1 commit intomainfrom Jun 13, 2025
Merged
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Contributor
Author
|
@kevin-v-ngo adding you to review so you're informed, not sure if this needs review beyond @jaiayu since we discussed on Slack a bit but y'all please let me know! |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@jaiayu what do you think of this one? happy to update if you have any feedback |
jaiayu
reviewed
Jun 3, 2025
jaiayu
approved these changes
Jun 3, 2025
jaiayu
left a comment
jaiayu
left a comment
There was a problem hiding this comment.
Thanks @rmloveland! LGTM! Just had one question on the frequency of reporting
taroface
approved these changes
Jun 12, 2025
Contributor
taroface
left a comment
taroface
left a comment
There was a problem hiding this comment.
LGTM with a couple suggestions. I only added these to 23.1, but they apply across versions.
Fixes DOC-13703 Summary of changes: - Replace mentions of 'anonymous' with 'obfuscated/redacted' - Remove mention of some details, and point users to the 'Telemetry Collected by CockroachDB' page, which is intended to be the comprehensive reference - Replace 'hourly' with 'periodic' updates so we don't have to keep touching this NB. Applied these changes to all supported versions v23.1+
rmloveland
force-pushed
the
20250520-DOC-13703-update-diagnostics-reporting
branch
from
49ed2cb to
c1a8d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DOC-13703
Summary of changes:
Replace mentions of 'anonymous' with 'obfuscated/redacted'
Remove mention of details, and point users to the 'Telemetry Collected by CockroachDB' page, which is intended to be the comprehensive reference